Vulkan #1608
Merged
Vulkan #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @kd-11 to be a potential reviewer |
| @@ -14,4 +14,5 @@ namespace vk | |||
| VkSamplerAddressMode vk_wrap_mode(u32 gcm_wrap); | |||
| float max_aniso(u32 gcm_aniso); | |||
| VkComponentMapping get_component_mapping(u32 format, u8 swizzle_mask); | |||
| VkPrimitiveTopology get_appropriate_topology(rsx::primitive_type& mode, bool &requires_modification); | |||
| } | |||
|
I like the program state optimization. The sampler changes should be fine as long as sampler creation cost is negligible. Its a little odd that we go to all the trouble to avoid recreating psos but then make it so that we recreate samplers. If sampler creation cost is close to nil this isn't an issue though. |
|
Fixed newline @kd-11 I didn't notice performance drop with this PR. I'm thinking to put every sampler in an unordered_map anyway and store image with their image_view in texture cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves program state creation into program_state_cache which should avoid a lot of creation/destruction. It also factorises sampler out of texture and use a more explicit ctor for framebuffer.