gl: Enable core context and debug output. #1618
Conversation
|
By analyzing the blame information on this pull request, we identified @kd-11, @DHrpcs3 and @Nekotekina to be potential reviewers |
|
Just to note, a debug context does make some opengl drivers significantly slower, even without synchronous output. edit: nvm about the performance thing, didn't see the Also, some more filtering by severity will probably useful, since some drivers swamp the debug output with performance hints. |
|
Core profile should help with most gpu debuggers. Should we also move shader validation to an if (debug) block or not? It should in theory only be called once per shader (first instance it is used) anyway and saps away at performance. |
| WX_GL_MAJOR_VERSION, 3, | ||
| WX_GL_MINOR_VERSION, 3, | ||
| WX_GL_CORE_PROFILE, | ||
| WX_GL_DEBUG, |
There was a problem hiding this comment.
Could just write conditional there.
There was a problem hiding this comment.
rpcs3::config.rsx.d3d12.debug_output.value() ? WX_GL_DEBUG : 0
There was a problem hiding this comment.
@Nekotekina That parameter does not take a value from looking at the sources. wxwidgets is inconsistent like that.
There was a problem hiding this comment.
@kd-11 I totally don't understand what you mean. I also tried my suggestion and it compiles fine.
|
Use conditionnal operator and rebased. |
| 0 | ||
| }; | ||
|
|
||
| m_canvas = new wxGLCanvas(this, wxID_ANY, context_attrs); |
There was a problem hiding this comment.
Line got removed for some reason.
|
I don't understand wxCheck_version returns true when wx_debug is not defined. |
vlj
force-pushed
the
gl
branch
13 times, most recently
from
9ba3bbf
to
5db42fc
Compare
vlj
force-pushed
the
gl
branch
2 times, most recently
from
638c280
to
855d693
Compare
No description provided.