gl: Fix texture cache bugs #2490
Conversation
kd-11
commented
Mar 10, 2017
kd-11
commented
- Fix endianness bug
- Fix r/w when real pitch is <= 64
- Fix deadlock/crash where secondary thread has lower priority than rsx::thread
|
@kd-11, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vlj, @Nekotekina and @raven02 to be potential reviewers. |
|
This should fix cases where write color buffers did not work, or colors were broken or black with it enabled. |
kd-11
force-pushed
the
texture_cache_fix
branch
from
a52c7b9
to
e7d862a
Compare
Fix endianness bug Fix r/w when real pitch is <= 64
kd-11
force-pushed
the
texture_cache_fix
branch
from
e7d862a
to
1fd33f6
Compare
| bool received = false; | ||
| gl::texture_cache::cached_rtt_section *section_to_flush = nullptr; | ||
|
|
||
| volatile bool processed = false; |
There was a problem hiding this comment.
doesn't really make them atomic if it is the intent.
There was a problem hiding this comment.
They aren't atomic, since the thread that receives this is waiting on the condition variable. Its just to keep the compiler from doing any shady optimizations.
There was a problem hiding this comment.
Ah, ok. If there won't be an issue with cache coherence and it's just for compiler optimizations it's fine.
There was a problem hiding this comment.
As far as I know x86 should not require explicit flushing so as long as the value is fetched from memory on consumer wake it should be fine. The values are just passed as a function result and the consumer does not actually use them.
|
Travis-ci is asleep it seems. |
|
Oh. Ok then. Thanks. |
