Minor changes for save data utility #3005
Conversation
Finished cellSaveDataGetListItem implementation Implemented cellSaveDataUserGetListItem Minor fixes to save_op
|
@Dangles91, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Nekotekina, @flash-fire and @TomiYuga to be potential reviewers. |
|
nice not sure if its this commit but it fixed tony hawk's proving ground load save game |
| @@ -83,6 +83,11 @@ static NEVER_INLINE s32 savedata_op(ppu_thread& ppu, u32 operation, u32 version, | |||
| vm::ptr<CellSaveDataFileSet> fileSet = g_savedata_context.ptr(&savedata_context::fileSet); | |||
|
|
|||
| // path of the specified user (00000001 by default) | |||
| if (userId == CELL_SYSUTIL_USERID_CURRENT) | |||
There was a problem hiding this comment.
It's already checked for zero later
There was a problem hiding this comment.
Would you prefer to remove the step for retrieving the current ID, where the TODO is. Or remove the check for 0 in the string initialisation?
| @@ -296,6 +314,10 @@ static NEVER_INLINE s32 savedata_op(ppu_thread& ppu, u32 operation, u32 version, | |||
| } | |||
| case CELL_SAVEDATA_FOCUSPOS_NEWDATA: | |||
| { | |||
| //focus new data, placed at the end of the vector. | |||
| // not currently supported in the ui | |||
There was a problem hiding this comment.
Wrong comments are missing the point, new data is focused on -1 value.
There was a problem hiding this comment.
This was emulate adding a new data item to the list. Instead we use a new save data button.
| @@ -60,10 +61,9 @@ std::mutex g_savedata_mutex; | |||
|
|
|||
| static NEVER_INLINE s32 savedata_op(ppu_thread& ppu, u32 operation, u32 version, vm::cptr<char> dirName, | |||
| u32 errDialog, PSetList setList, PSetBuf setBuf, PFuncList funcList, PFuncFixed funcFixed, PFuncStat funcStat, | |||
| PFuncFile funcFile, u32 container, u32 unknown, vm::ptr<void> userdata, u32 userId, PFuncDone funcDone) | |||
| PFuncFile funcFile, u32 container, u32 unknown, vm::ptr<void> userdata, u32 userId) | |||
There was a problem hiding this comment.
Nope, this megafunction was modelled after an existing one. The arguments, their positions were preserved.
There was a problem hiding this comment.
I'll chuck this back in on the next commit
rpcs3/Emu/Cell/Modules/cellSysutil.h
Outdated
| @@ -79,6 +79,8 @@ enum | |||
| CELL_SYSUTIL_SYSCHAT_STOP = 0x0162, | |||
| CELL_SYSUTIL_SYSCHAT_VOICE_STREAMING_RESUMED = 0x0163, | |||
| CELL_SYSUTIL_SYSCHAT_VOICE_STREAMING_PAUSED = 0x0164, | |||
|
|
|||
| CELL_SYSUTIL_USERID_CURRENT = 0, | |||
There was a problem hiding this comment.
This repeats definition in another file. Just use zeros everywhere, it doesn't matter.
|
Stop spamming with all these things. |
Finished cellSaveDataGetListItem implementation
Implemented cellSaveDataUserGetListItem
-- this will help games like RDR and Minecraft load correctly
Minor fixes to save_op
Added comments for future UI behaviours
Removed PFuncDone callback from save_op, not used or required.