Optimize SPU interpreter #4223
Merged
Optimize SPU interpreter #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
Feb 27, 2018
| // Next instruction | ||
| pc += 4; | ||
| // Decode single instruction (may be step) | ||
| const u32 op = *reinterpret_cast<const be_t<u32>*>(base + pc); |
There was a problem hiding this comment.
well, if you already put this optimization in your pr, I might close mine
There was a problem hiding this comment.
I'll wait for testing. It once almost doubled PPU performance, buf I have no idea how it will affect SPU.
Closed
Nekotekina
force-pushed
the
master
branch
4 times, most recently
from
0525a32
to
75f4260
Compare
Added operators ==, !=, >, <, >=, <=
Made SPU decoder similar to PPU decoder
Use atomic variable to sync TTY size Implement console_putc (liblv2) Write plaintext instead of HTML Slightly improve performance Fix random line breaks in TTY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.