Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPUTranslator: Ignore relative relocations #4278

Merged
merged 2 commits into from
Mar 31, 2018

Conversation

VelocityRa
Copy link
Member

Fixes at least the following on LLVM recompiler:

  • Portal 2
  • Castlevania: Harmony of Despair
  • FIFA 12

@Nekotekina Seems like the translator handles this just fine in emitted instructions (saw it being used for the bc instruction), but they weren't properly ignored.
I included all relevant relative relocations as comments and only left out relocation type 11 which we know for sure works because of aforementioned games.
I could remove the commented ones or if you think they'd work as well, uncomment them.

@VelocityRa VelocityRa force-pushed the ppu-reloc-fix branch 3 times, most recently from e4805be to 686c8c5 Compare March 14, 2018 18:06
@Nekotekina Nekotekina merged commit 706faa1 into RPCS3:master Mar 31, 2018
@JackTerok
Copy link

Problem is with this PR "0:00:13.611047 PPU: Ignoring relative relocation at 0x2454f0 (11)" gets spammed in log making it over 500mb in minutes with so many lines that even Notepad++ cant open it.

@danilaml
Copy link
Contributor

danilaml commented Apr 1, 2018

@jackoneill12 can't you set your log level higher?

@JackTerok
Copy link

@danilaml The complete log gets written to the file anyway. The log level only seems to affect whats shown in the console.

@AniLeo
Copy link
Member

AniLeo commented Apr 1, 2018

Then set your log level higher on the config's log section itself not on the emulator's log console

@VelocityRa VelocityRa deleted the ppu-reloc-fix branch April 1, 2018 14:18
@VelocityRa
Copy link
Member Author

Not sure if I should make a new PR just for this... Is it actually a problem or does it only occur in one game?

@JackTerok
Copy link

The log part of the config is empty. What would be the correct syntax to change the log level there?

@Nekotekina
Copy link
Member

Log: {PPU: Error, sys_rsx: Fatal}

@JackTerok
Copy link

JackTerok commented Apr 1, 2018

Thx.

EDIT: even with both set to fatal its still spamming "0:00:05.089700 {PPU[0x1000000] Thread (main_thread) [0x001139ac]} LDR: **** RELOCATION(11): 0x169f22c <- 0x000003 (0x169f238)"

200k Lines in 5 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants