Partial compilation fixes for osx #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd-11
reviewed
Mar 24, 2018
| @@ -57,6 +57,6 @@ void gl::set_swapinterval(int interval) | |||
| //No existing drawable or missing swap extension, EGL? | |||
| LOG_ERROR(RSX, "Failed to set swap interval"); | |||
| #else | |||
| LOG_UNIMPLEMENTED(RSX, "Swap control not implemented for this platform. Vsync options not available."); | |||
| LOG_ERROR(RSX, "Swap control not implemented for this platform. Vsync options not available."); | |||
There was a problem hiding this comment.
Thanks, I was just prototyping and the code got left in there since neither windows nor linux hit this assert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOG_UNIMPLEMENTEDdoes not exist, replaced byLOG_ERRORWith these changes, it is possible to build RPCS3 without LLVM support on OSX.