Load stylesheets properly when in AppImage or make install #4364
Conversation
|
If it works then it should be fine |
|
Yes, it works |
rpcs3/rpcs3qt/gui_settings.cpp
Outdated
| for (const QFileInfo &entry : linux_entries) | ||
| { | ||
| res.append(entry.baseName()); | ||
| } |
There was a problem hiding this comment.
I just noticed these code blocks were already implemented as a reuseable function in gui::utils::get_dir_entries in qt_utils.cpp
you might just use: res.append(gui::utils::get_dir_entries(dir, nameFilter));
same goes for the guiconfigs part above.
(If it makes sense to do that)
rpcs3/rpcs3qt/gui_settings.cpp
Outdated
| res.removeDuplicates(); | ||
| #endif | ||
| res.sort(Qt::CaseInsensitive); | ||
|
|
There was a problem hiding this comment.
are these 4 lines of space indentations (244-247) the unwanted abomination I was talking about?
is this april fools?
There was a problem hiding this comment.
I'm not seeing them. Maybe just April Fools on your end?
There was a problem hiding this comment.
oh wait, nvm, I dunno what happened there.
|
@Nekotekina I've taken BSDs into account, ready for merge? |
-Wno-invalid-pchwas added because it was spammed constantly by gcc on Arch Linux.
-Wno-unused-command-line-argumentwas added because it was occasionally spammed, during the build.