Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PPU disasm for branch opcodes with AA or LK set #4432

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Fix PPU disasm for branch opcodes with AA or LK set #4432

merged 1 commit into from
Apr 16, 2018

Conversation

tge-was-taken
Copy link
Contributor

@Nekotekina
Copy link
Member

We use op.bt24 for target address, "strange" ll is seemingly left to allow emitting B instruction, because bt24 is not writable.

@tge-was-taken
Copy link
Contributor Author

I'm aware, I checked. I assumed it was there for the sake of uniformity with the spec (albeit misspelled).

@Nekotekina
Copy link
Member

Leave them both as well as code in B emitter

@tge-was-taken
Copy link
Contributor Author

Fixed

@Nekotekina
Copy link
Member

Ok, thanks

@Nekotekina Nekotekina merged commit 6baf675 into RPCS3:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tge-was-taken @Nekotekina