Cmake improvements #4578
Merged
Cmake improvements #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcorion
approved these changes
May 14, 2018
Orphis
suggested changes
May 17, 2018
rpcs3/CMakeLists.txt
Outdated
| @@ -124,7 +128,7 @@ if(NOT MSVC) | |||
|
|
|||
| add_compile_options(-msse -msse2 -mcx16 -mrtm) | |||
|
|
|||
| if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") | |||
| if(${CMAKE_CXX_COMPILER_ID} MATCHES "Clang") | |||
There was a problem hiding this comment.
This is a case of double expansion, drop the ${} around the variable name.
There was a problem hiding this comment.
Indeed, thank you for the review
rpcs3/CMakeLists.txt
Outdated
| @@ -107,7 +107,11 @@ if(USE_NATIVE_INSTRUCTIONS) | |||
| endif() | |||
|
|
|||
| if(NOT MSVC) | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-invalid-pch -Wno-unused-command-line-argument -fexceptions") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-invalid-pch -fexceptions") | |||
| if(${CMAKE_CXX_COMPILER_ID} MATCHES "Clang") | |||
There was a problem hiding this comment.
This is a case of double expansion, drop the ${} around the variable name.
It was introduced in commit 855d693 and used in the file rpcs3/Gui/GLGSFrame.cpp (wxWidgets) which doesn't exist anymore.
…sn't have this option)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements/cleanup for the CMake build system + cotire 1.8.0
Changelog for cotire 1.8.0