-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay GDB server launch until emulator run #4658
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad.lock() some personal notes: * possibly select_thread bug? * seems to happen whenever the debugger is attached when the RPCS3 engine is not yet booted, i.e. at program launchtime * seems to break launching games as well
elad335
reviewed
May 25, 2018
rpcs3/Emu/System.cpp
Outdated
@@ -239,8 +239,10 @@ void Emulator::Init() | |||
fs::create_path(dev_usb); | |||
|
|||
#ifdef WITH_GDB_DEBUGGER | |||
fxm::make<GDBDebugServer>(); | |||
// TODO: using legacy call to logger -- should be switched to log::GENERAL.SUCCESS(...)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using LOG_SUCCESS is fine
Utilities/GDBDebugServer.cpp
Outdated
@@ -338,6 +338,7 @@ bool GDBDebugServer::select_thread(u64 id) | |||
selected_thread = ppu.ptr; | |||
return true; | |||
} | |||
gdbDebugServer.warning("Unable to select thread! Is the emulator running?" HERE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need in "HERE"
…ode/line number in gdbDebugServer fail message
kd-11
approved these changes
May 31, 2018
Needs rebasing and squashing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shifts a few lines of code to delay the GDB server from running until the emulator itself actually begins.
As it stands the GDB server starts and awaits connections as soon as RPCS3 is launched but before any emulation. Attempting to attach GDB will cause RPCS3 to segfault by deferencing a nullptr, specifically
th
in the command parser functions, becauseselect_thread
wasn't able to select a thread and left theselected_thread
pointer empty, because the CPU isn't running.Example GDB trace of the segmentation fault:
which corresponds to one of the first invoked commands
rpcs3/Utilities/GDBDebugServer.cpp
Lines 585 to 591 in c09c792