Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asmjit: update build integration #4748

Merged
merged 4 commits into from
Jun 14, 2018
Merged

asmjit: update build integration #4748

merged 4 commits into from
Jun 14, 2018

Conversation

scribam
Copy link
Contributor

@scribam scribam commented Jun 12, 2018

@kd-11
Copy link
Contributor

kd-11 commented Jun 12, 2018

In future if possible lump the submodule updates in one PR (separate commits of course) otherwise its a chore to merge these.

@scribam
Copy link
Contributor Author

scribam commented Jun 12, 2018

No submodule updates on this one :) but I get your point, I will keep it in mind.
However, I will be interested to know more about how the core team proceeds with reviews and merges, and if there is anything the contributors can do to speed up these processes.

@kd-11
Copy link
Contributor

kd-11 commented Jun 13, 2018

Well, if youre updating build integration for example, have it all in one place. You can mark it as WIP while you add more parts to it. Merging will happen one PR at a time, likely with some time in between (you have to start a new build after every merge as the PRs become outdated after each merging). As for review, things like build integration aren't too critical as they do not actually change emulator functionality. For emulation changes, provide ps3 tests proving the commits are correct and it can get merged in minutes.

@Nekotekina Nekotekina merged commit 21a7f1a into RPCS3:master Jun 14, 2018
@scribam scribam deleted the asmjit branch June 14, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants