-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cellGameDataCheckCreate2 #4832
Conversation
rpcs3/Loader/PSF.cpp
Outdated
@@ -187,7 +187,7 @@ namespace psf | |||
|
|||
void save_object(const fs::file& stream, const psf::registry& psf) | |||
{ | |||
std::vector<def_table_t> indices; indices.reserve(psf.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without this change it works
rpcs3/Emu/Cell/Modules/cellGame.cpp
Outdated
@@ -479,7 +477,7 @@ error_code cellGameDataCheckCreate2(ppu_thread& ppu, u32 version, vm::cptr<char> | |||
cbGet->sizeKB = CELL_GAMEDATA_SIZEKB_NOTCALC; | |||
cbGet->sysSizeKB = 0; | |||
|
|||
psf::registry sfo = psf::load_object(fs::file(vfs::get(dir + "/PARAM.SFO"))); | |||
psf::registry sfo = psf::load_object(fs::file(vfs::get(dir + "/PARAM.SFO"), fs::read)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is placebo change (default parameter)
Its a default parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the game in question works fine now
Attempting to fix #4823