Fix cellSysCacheClear #4848
Merged
Fix cellSysCacheClear #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Like i have already explain, this PR fix issue cache for heavy rain and beyond |
Kravickas
approved these changes
Jul 5, 2018
|
Now for Demon Souls and Ni No Kuni to receive similar fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dont remove cache directory after clear, only clear cache dir's content.
Fix cache dir path returned
Fix 'error' code returned in cellSysCacheMount
the testcase I created tries to create cache dir twice, first error code is
CELL_SYSCACHE_RET_OK_CLEARED(0), second isCELL_SYSCACHE_RET_OK_RELAYED(1)then tries to create file.txt inside the folder cache, clear cache, and trying to get that file again, this fails with
CELL_ENOENT, indicating the deletion of the file.but recreating the file works and returned
CELL_OK, indicating that the cache dir is NOT removed and is still usable.fixes #4470
pinging @Kravickas to retest