MFC: Fix barrier type transfers #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You imply that stalled list without barrier blocks a command with a barrier which is issued later on the same tag? It doesn't seem to work this way. |
Nekotekina
reviewed
Jul 10, 2018
rpcs3/Emu/Cell/SPUThread.cpp
Outdated
| @@ -935,6 +935,11 @@ bool SPUThread::do_dma_check(const spu_mfc_cmd& args) | |||
| return true; | |||
| } | |||
|
|
|||
| if (args.cmd & MFC_BARRIER_MASK) | |||
There was a problem hiding this comment.
it's for blocking further commands until the barrier command is dealt with.
There was a problem hiding this comment.
It's set after do_dma_check call
elad335
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this add a missing check for barrier type transfers when processing the command queue, making these commands wait until the previously issued commands from the same tag group complete.
testcase