Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme dependency cleanup #4930

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Readme dependency cleanup #4930

merged 1 commit into from
Aug 7, 2018

Conversation

JohnHolmesII
Copy link
Contributor

  • Added wiki link
  • Remove "required" from dependency list. The word "dependency" implies requirement, therefore only optionality is notable.
  • Update Vulkan links to point to latest always
  • Added link to Vulkan config instructions, which describes how to ensure environment vars are set correctly (some people have had trouble with this)
  • Remove redundant Qt config info, as it's already in the dependency list
  • Various minor typo fixes

@JohnHolmesII
Copy link
Contributor Author

JohnHolmesII commented Jul 26, 2018

I'm actually looking at it more and more. Should we even mention the qt plugin? If someone wants to use it, they should be able to figure it out on their own right? There's tons of optional software out there, should we even bother mentioning that?

I reduced it's importance to clarify it's optionality.

@JohnHolmesII JohnHolmesII changed the title Readme update Readme dependency cleanup Jul 26, 2018
README.md Outdated
@@ -6,7 +6,7 @@ RPCS3

The world's first open-source PlayStation 3 emulator/debugger written in C++ for Windows and Linux.

You can find some basic information in our [**website**](https://rpcs3.net/).
You can find some basic information in our [**website**](https://rpcs3.net/). Game info is being moved to the [**wiki**](https://wiki.rpcs3.net/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's "Game info is being moved to the wiki"? Doesn't make sense. Edit next line and make it "visit our forums, wiki and our discord server".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the text is best served if each location has a description of its function.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make sense because anything stuff is not being moved, wiki is being populated with mostly new data and some stuff from the existing forum threads.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright that works

@JohnHolmesII
Copy link
Contributor Author

@AniLeo Thoughts?

@Nekotekina Nekotekina merged commit 451b3f3 into RPCS3:master Aug 7, 2018
@JohnHolmesII JohnHolmesII deleted the readme branch September 9, 2018 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants