Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: implement first Mouse Movement for keyboard pad handler #4957

Merged
merged 4 commits into from
Aug 30, 2018

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Aug 5, 2018

Let's you map the mouse movement to buttons in the keyboard pad handler. In order to do so you will need to click a button in the pad settings dialog and then click it again and - while keeping the left mouse button pressed - move the mouse in a direction. This will most likely interfere with the basic mouse handler in the I/O settings.

Extra options in the game window (for now):
Alt + T or Y change native deadzone x-axis
Alt + U or I change native deadzone y-axis
Alt + G or H change multiplier for x-axis
Alt + J or K change multiplier for y-axis

native deadzone = the game's own deadzone.
This means you have to increase this value depending on your game. This is not an added deadzone to our input, but rather a bypass for an existing one. So if the game has a deadzone of 60 and ours is 50, we will have to move the mouse by at least 10 points per input (much).

multiplier = multiply the raw mouse movement before adding the deadzone value (default is 2.0).

@Psycho-A
Copy link

Psycho-A commented Aug 6, 2018

Finally!

@Parthorisian
Copy link

Wow, so since this PR we don't need gpdsck3.1-3.3b for for shooters? Unbelievable!

@Megamouse
Copy link
Contributor Author

Idk about that app, but you can try and compare and report your findings

@Megamouse Megamouse merged commit f933947 into RPCS3:master Aug 30, 2018
@deltix

This comment has been minimized.

@13xforever

This comment has been minimized.

@deltix

This comment has been minimized.

@AniLeo
Copy link
Member

AniLeo commented Aug 30, 2018

If you're drunk, please avoid using our tracker - we appreciate

@ruipin
Copy link
Contributor

ruipin commented Aug 30, 2018

It seems this PR has caused Resistance: Fall of Mankind to regress. After selecting the campaign, this game reboots with a different executable loading directly into the campaign. However after this PR, it gets stuck and never closes the menu. Tested it with the build before this and it works fine there.

@Megamouse
Copy link
Contributor Author

Megamouse commented Sep 1, 2018

Are you sure? I cant imagine any of the changes would cause something like that

@ruipin
Copy link
Contributor

ruipin commented Sep 1, 2018

I'm not completely sure, but I only see that on master after this PR got merged. However, it might just be a race condition or something. The game seems to spam a lot of cellPad messages when it gets stuck so it could definitely be related:

E {PPU[0x1000000] Thread (main_thread) [0x000e35c0]} 'cellPadGetData' failed with 0x80121107 : CELL_PAD_ERROR_NO_DEVICE [2]
E {PPU[0x1000000] Thread (main_thread) [0x000e35c0]} 'cellPadGetData' failed with 0x80121107 : CELL_PAD_ERROR_NO_DEVICE [3]
E {PPU[0x1000000] Thread (main_thread)} Stat: 'cellPadGetData' failed with 0x80121107 : CELL_PAD_ERROR_NO_DEVICE [x714]

This does not happen on the working builds.

@Megamouse
Copy link
Contributor Author

you could try to revert the functions to s32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants