New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header file refactoring and cleaning #5178
Conversation
9ee683c
to
9b203a2
Compare
Went manually through most of the files to remove most of the unnecessary #includes Moved Removed 'WIP' tag |
RSX/GCM changes are good, but will need review by other developers before merge as it touches well outside my purview. |
Also needs conflicts to be solved (cellAudio.h) and rebase |
9b203a2
to
5869d3a
Compare
Rebased. Only non-trivial changes outside RSX are Emu/Memory refactoring in the first commit. |
6a90908
to
c215f8f
Compare
c215f8f
to
bcd0d66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSX side of things was resolved and is ok, but this still needs reviews from multiple other contributors.
Need rebase and fix few conflict |
@kukkamario do you want to try again? |
I'll try to check, is this still salvageable pull request next week. I'm busy this week and there are lot of conflicts. |
@kukkamario Any update on this? |
- Add vm_locking.h and vm_reservation.h and move relevant functions and types to these headers. - Change include order and make vm_ptr.h, vm_var.h and vm_ref.h headers usable invidually and them including vm.h instead of other way around - Because usage of vm::ptr now requires including vm_ptr.h instead of vm.h updated multiple #includes - Added additional #includes to vm_reservation.h and vm_locking to where vm::reservation_* and locking related functions are used
3ff5a92
to
88e1ca0
Compare
Okey... I finally had time to spend full day with updating my development setup and rebasing this. |
- Multiple header files where missing #includes to other headers that where used in the header. Correct header was included in correct order in source files which caused everything to compile. - Added missing #includes so header files correctly include all their dependencies and fixes problems with IDEs being unable to parse headers correctly due to missing symbols
- Manually removed lot of unneeded #includes to clean code and reduce compilation time - Reordered some of the #includes to be in more logical order
88e1ca0
to
856a09e
Compare
and types to these headers.
usable invidually and them including vm.h instead of other way around
vm.h updated multiple #includes
where vm::reservation_* and locking related functions are used
where used in the header. Correct header was included in correct
order in source files which caused everything to compile.
dependencies and fixes problems with IDEs being unable to parse
headers correctly due to missing symbols