ppu: Stack fixup #5214
Merged
ppu: Stack fixup #5214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the Back to the Future series intro crash. BTTF screenshot
|
|
Tests are messy TBH, and don't seem to utilize sys_ppu_thread_get_stack_information to get more readable information. |
|
The syscall provides initial stack address of the allocation, im looking for the current offset from the allcation end, which can only be pulled directly from the register itself. (even though the stack gap fix could still be figured out using the syscall only) |
|
Offset you talk about is (stack addr + stack size - stack value), it's computed from 3 variables only 1 of them you print. |
|
Have updated the tests according to your advice. Results.txt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes: fix base offset from stack allocation.
This was tested on both ppu interrupt thread and a non-joinable non-interruptable thread.
testcases: non-interrupt thread, interrupt thread
results.txt
The only mismatch left is in main thread stack offset, which is related to https://github.com/elad335/rpcs3/blob/1e7eeaad504c3c11d6b5464023b10cc97daafa6b/rpcs3/Emu/Cell/PPUModule.cpp#L1484 so I will leave it untouched atm.
Fixes High Velocity Bowling [NPEA00047] access violations with any(?) version that is not v1.0.