Qt: set Vulkan surface in gs_frame #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Oct 19, 2018
rpcs3/rpcs3qt/gs_frame.cpp
Outdated
| @@ -28,6 +28,9 @@ constexpr auto qstr = QString::fromStdString; | |||
| gs_frame::gs_frame(const QString& title, const QRect& geometry, QIcon appIcon, bool disableMouse) | |||
| : QWindow(), m_windowTitle(title), m_disable_mouse(disableMouse) | |||
| { | |||
| // Needed for MoltenVK to work properly on MacOS | |||
| if (g_cfg.video.renderer == video_renderer::vulkan) | |||
There was a problem hiding this comment.
why not put this in front of the other setters?
Also.... vertical spacing?
There was a problem hiding this comment.
I think this block should be behind a preprocessor select for apple only.
hcorion
force-pushed
the
hacktoberfest-4
branch
from
e472525
to
9cedd51
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for MoltenVK on MacOS, however the Vulkan->MoltenVK correlation was only established in Qt 5.12, so if you want to test MoltenVK (hint: it doesn't work nearly as well as gfx-rs/portability) you'll need to use the Qt 5.12 Beta as of right now.
Requesting review from @Megamouse