Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth returns select as KEY_BACK for XBOX ONE controller. #5303

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

RipleyTom
Copy link
Contributor

No description provided.

@moll
Copy link

moll commented Nov 3, 2018

Wouldn't it be perhaps more intuitive to have it read "Back Key" or something?

@Megamouse
Copy link
Contributor

Megamouse commented Nov 3, 2018

because that's the key's name.

ups, yeah. it is better to call it back key or key back.

Also.. @RipleyTom why put the key there?
also you might as well add any other key

@RipleyTom
Copy link
Contributor Author

I put the extra entries at the end with a comment to show why they're there and changed the names.
As far as I know those are the only keys affected(source: paroj/xpad#53 which is the only page I found relevant to the issue).

@@ -1,4 +1,4 @@
#pragma once
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this always happening on your files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember right I had to set VS2017 to save as UTF8 without signature, otherwise it would add signature for my local codepage. It's done automatically.

Copy link

@hch12907 hch12907 Nov 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But UTF8 without signature should leave the files without the BOM mark... unless I am misunderstanding something

Copy link
Contributor Author

@RipleyTom RipleyTom Nov 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked and the file is now encoded with UTF-8-BOM which should be fine?
It went from UTF-8 to UTF-8-BOM to be exact.

@AniLeo AniLeo merged commit 9831bc6 into RPCS3:master Nov 5, 2018
@RPCS3 RPCS3 deleted a comment from TROguz Nov 5, 2018
@RipleyTom RipleyTom deleted the ExtraKey branch June 4, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants