Extra check when opening pup file #5321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Nov 9, 2018
rpcs3/rpcs3qt/main_window.cpp
Outdated
| if (!pup_f) | ||
| { | ||
| LOG_ERROR(GENERAL, "Error opening PUP file %s", path); | ||
| QMessageBox::critical(this, tr("Failure!"), tr("Firmware file selected couldn't be opened.")); |
There was a problem hiding this comment.
Idk if my english got worse but that sounds weird
There was a problem hiding this comment.
This sounds better to me
Suggested change
| QMessageBox::critical(this, tr("Failure!"), tr("Firmware file selected couldn't be opened.")); | |
| QMessageBox::critical(this, tr("Failure!"), tr("The selected Firmware file couldn't be opened.")); |
There was a problem hiding this comment.
Not sure why firmware needs capitalization, but this looks 100.
Suggested change
| QMessageBox::critical(this, tr("Failure!"), tr("Firmware file selected couldn't be opened.")); | |
| QMessageBox::critical(this, tr("Failure!"), tr("The selected firmware file couldn't be opened.")); |
RipleyTom
force-pushed
the
ExtraCheck
branch
from
5e14dd8
to
9588942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extra check to avoid "fs::file is null" exception in the event that the pup file couldn't be opened.