Increases default stack allocation for callbacks #5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RipleyTom
force-pushed
the
ExtraStack
branch
2 times, most recently
from
ef5cd98
to
9c1d4af
Compare
|
|
RipleyTom
force-pushed
the
ExtraStack
branch
from
9c1d4af
to
b067385
Compare
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Feb 9, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Feb 9, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Feb 9, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Feb 9, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Feb 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves "Afrika" a bit further ingame.
Before it died because a callback stores a value at r1[0x30]
seg001:002604A8 stdu r1, -0x40(r1)
seg001:002604AC std r31, 0x38(r1)
seg001:002604B0 mr r31, r1
seg001:002604B4 std r3, 0x70(r31) <- stores a value at +0x30 over the previous stack value
With previous stack allocation r1[0x30] was the r1[0] for the previous caller which is where is stored the saved stack.