sys_memery fix #5338
Merged
sys_memery fix #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the following issue with Ridge Racer 7 [NPUB30457] (and other games that try to call those functions with nullptr as alloc_addr) |
AniLeo
approved these changes
Nov 14, 2018
elad335
approved these changes
Nov 14, 2018
|
|
janisozaur
reviewed
Nov 14, 2018
| @@ -1,4 +1,4 @@ | |||
| #include "stdafx.h" | |||
| #include "stdafx.h" | |||
There was a problem hiding this comment.
Why is BOM necessary here?
There was a problem hiding this comment.
This project uses BOM for some reason
Line 4 in 0e0a82e
It's stupid, but that's what the project has decided to do.
There was a problem hiding this comment.
This was decided after multiple contributors had issues where an editor or the compiler didn't auto-detect UTF-8 properly and broke stuff such as log messages, and were painful to fix.
BOM was added since it doesn't really hurt anybody (other than the diffs being annoying for a while) and ensures this never happens again no matter what fancy editor or compiler people decide to use.
Nekotekina
reviewed
Nov 14, 2018
…cate_from_container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add null alloc_addr checks to sys_memory_allocate and sys_memory_allocate_from_container.
testcase
Some game was doing this according to ani.