Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache removal options #5558

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Fix cache removal options #5558

merged 1 commit into from
Jan 16, 2019

Conversation

MSuih
Copy link
Member

@MSuih MSuih commented Jan 15, 2019

Adjusts RemoveShadersCache, RemovePPUCache and RemoveSPUCache to use the new cache location and thus makes these functions work again when rightclicking items in game list.

Fixes #5557

@Nekotekina
Copy link
Member

Are they tested to actualy delete new cache? May need some adjustments.

@JohnHolmesII
Copy link
Contributor

There's also the right click -> make ppu cache failing silently

@Kravickas
Copy link
Contributor

u could add option Open Cache Folder, under the Open Install Folder and Open Config Folder

@Megamouse
Copy link
Contributor

Megamouse commented Jan 15, 2019

@Nekotekina I just tried and all the related files in the cache dir were deleted as expected.
(Subdirectories are scanned as well)

@MSuih
Copy link
Member Author

MSuih commented Jan 16, 2019

@Nekotekina Yes. I did test this before creating a pull request. The removal functions are very dumb, they just recursevily iterate the directory and remove files ending with ".obj" or ".dat", or a folder named "shaders_cache". They don't care about cache versions or anything like that, all they need is to get pointed at the right directory.

@Kravickas I'll try to keep the scope of this pull request as small as possible so that it can be quickly merged. Megamouse has open PR for some misc improvements, you could do feature requests there.

@JohnHolmesII I looked at it and I've no idea why it doesnt work. I'll let Megamouse fiddle with it, it's not very useful feature even when it works.

@Megamouse Megamouse merged commit f902a78 into RPCS3:master Jan 16, 2019
@MSuih MSuih deleted the fixCacheDelete branch January 16, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants