Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Fix unknown vertex base types #5585

Merged
merged 1 commit into from
Jan 21, 2019
Merged

rsx: Fix unknown vertex base types #5585

merged 1 commit into from
Jan 21, 2019

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Jan 21, 2019

  • Clamp vertex type field into 3-bit instead of 4-bit value, vertex type 0 is the same as ub256.

Testcase : https://github.com/elad335/myps3tests/tree/master/rsx_tests/vertex%20base%20type%200

Testing conditions:

  • all vertex base types are being ORed with 0x8, this doesnt affect the results on realhw but crashes on rpcs3.

  • Vertex base type 0 is used for POSITION array, values of ub256 are being passed and normalized manually into [-1, +1] by doing new_value = ((value) - 128) / 128 in the vertex shader.
    Rendering works and produces normal image.

Fixes #5582
Fixes #2408

Clamp vertex type field into 3-bits instead of 4-bit value
Case 0 is UB256
@xYaroslavGTx
Copy link

screenshot_175

@elad335
Copy link
Contributor Author

elad335 commented Jan 21, 2019

To make things clear this is not a graphical fix, this only affects games which used to throw the exception mentioned in the title.

@digitaldude555
Copy link

screenshot 1832
The error is gone, it's now ingame.
screenshot 1833
The error is gone from Absolute Supercars and Ferrari Race Experience., they reach menu now.

@digitaldude555
Copy link

screenshot 1834
Correction they go ingame.

@xYaroslavGTx
Copy link

To make things clear this is not a graphical fix, this only affects games which used to throw the exception mentioned in the title.

Yep, but this PR added 0.4 - 0.6 FPS to this game.

@kd-11 kd-11 merged commit 688d5a9 into RPCS3:master Jan 21, 2019
@elad335 elad335 deleted the vertex_base branch January 22, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants