Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup for sys_lwcond_signal_x error checking #5623

Merged
merged 2 commits into from Feb 10, 2019
Merged

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Feb 1, 2019

in sys_lwcond_signal:

  • Check for EPERM in mode 2 if a specific ppu thread id was specified.
  • Move ENOENT check of mode 3 to unspecific ppu thread id handling.
  • If the ppu thread id target does not belong to a thread, return ESRCH.

both:

  • Mode 2 doesnt use the lwmutex, therefore ESRCH check for lwmutex id doesnt occur.

testcase, results:

master:

lwcond_signal(null id, mode 1) returned 0x80010009
lwcond_signal(main_thread, mode 2) returned 0x0
lwcond_signal(-1 id, mode 2) returned 0x0
lwcond_signal(main_thread, mode 3) returned 0x80010006
lwcond_signal(-1 id, mode 3) returned 0x80010009
lwcond_signal_all(invalid mtx, mode 2) returned 0x80010005

realhw:

lwcond_signal(null id, mode 1) returned 0x80010005
lwcond_signal(main_thread, mode 2) returned 0x80010009
lwcond_signal(-1 id, mode 2) returned 0x0
lwcond_signal(main_thread, mode 3) returned 0x80010009
lwcond_signal(-1 id, mode 3) returned 0x80010006
lwcond_signal_all(invalid mtx, mode 2) returned 0x0

@elad335 elad335 force-pushed the master branch 4 times, most recently from 151efdd to 8aff0b8 Compare February 2, 2019 07:49
@elad335
Copy link
Contributor Author

elad335 commented Feb 2, 2019

I've changed a few things in sys_mutex_unlock, I need testers to confirm that Demon's souls 4c4t issue is still solved.

@elad335 elad335 force-pushed the master branch 2 times, most recently from 34f485a to a1ab489 Compare February 2, 2019 08:18
@psennermann
Copy link

For me DeS seems to work fine (i5 7400)

@Dani1977
Copy link

Dani1977 commented Feb 2, 2019

Hi,
i have i7-7700K this is my log for DeS, work ok

RPCS3.log.gz

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants