Make sys_spu_thread_group_join return once per termination #5643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
spu-group-join-accuracy
branch
4 times, most recently
from
e4f1b74
to
1469c8a
Compare
Nekotekina
requested changes
Feb 9, 2019
elad335
force-pushed
the
spu-group-join-accuracy
branch
2 times, most recently
from
9b354fa
to
56ca5a1
Compare
elad335
force-pushed
the
spu-group-join-accuracy
branch
from
56ca5a1
to
75d4629
Compare
|
Ugh why you change stack arg positioning? |
elad335
force-pushed
the
spu-group-join-accuracy
branch
2 times, most recently
from
bd3684c
to
fdc9a52
Compare
Order of checks is based on firmware
elad335
force-pushed
the
spu-group-join-accuracy
branch
from
fdc9a52
to
f0b2300
Compare
Nekotekina
added a commit
to Nekotekina/rpcs3
that referenced
this pull request
Feb 9, 2019
Nekotekina
added a commit
to Nekotekina/rpcs3
that referenced
this pull request
Feb 10, 2019
After waiting, thread group cannot be safely accessed Following RPCS3#5643
Nekotekina
added a commit
to Nekotekina/rpcs3
that referenced
this pull request
Feb 27, 2019
After waiting, thread group cannot be safely accessed Following RPCS3#5643
Nekotekina
added a commit
to Nekotekina/rpcs3
that referenced
this pull request
Feb 28, 2019
After waiting, thread group cannot be safely accessed Following RPCS3#5643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the amount of times sys_spu_thread_group_join returned always be equal to the amount of times sys_spu_thread_group_start was called, and the amount of times a termination signal was signaled.
This also means that when executing a second sys_spu_thread_group_join, it waits until another signal will be received.
In theory, to exit from this situation another thread has to call sys_spu_thread_group_start, and waiting until the SPUs signal termination again.
Source for this:
https://user-images.githubusercontent.com/18193363/52517440-0bdde300-2c44-11e9-8c52-773a9de5a233.png
Past tests hinted this behavior, although it was unclear if an absolute deadlock occurs on the second sys_spu_thread_group_join execution, or how to exit from this situation.