Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RSX replayer using sys_memory_allocate, Ensure rsxio memory is valid #5677

Merged
merged 2 commits into from Mar 5, 2019
Merged

Fix RSX replayer using sys_memory_allocate, Ensure rsxio memory is valid #5677

merged 2 commits into from Mar 5, 2019

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Feb 21, 2019 •
edited

  • Use sys_memory_allocater in rsx capture replay to fix missing memory block in allocations.
  • Fix 0 vm page flags in all cases. use 1m page flags in that case.
  • Make vm::alloc register page flags based on area's flags instead of raw alignment passed.
  • Ensure memory mapped by sys_rsx_context_iomap is valid.

Fixes rsx replayer regression after #5502.

@elad335 elad335 force-pushed the rsx-io branch 5 times, most recently from ebf79cf to 86567db Compare February 21, 2019 16:03
@AniLeo AniLeo requested a review from kd-11 February 26, 2019 20:05
kd-11
kd-11 reviewed Feb 27, 2019
View reviewed changes
Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to RSX code seem to be ok, not sure about vm stuff though.

@elad335
Use sys_memory_allocate on rsx replayer to fix it
f04628a
@elad335
check address in sys_rsx_context_iomap
f6e19b3 
* Fix 0 vm page flags to behave like 1m flags, follows c8a681e
* check if address exists and valid for rsx io allcations (must be allocated on 1m pages)
@elad335 elad335 changed the title Fix rsx replayer using sys_memory_allocate, check address in rsxio mapping Fix RSX replayer using sys_memory_allocate, Ensure rsxio memory is valid Mar 5, 2019
@Nekotekina Nekotekina merged commit e38b7ae into RPCS3:master Mar 5, 2019
@elad335 elad335 deleted the rsx-io branch March 5, 2019 19:25
@kding99 kding99 mentioned this pull request Apr 10, 2019
Closed
elad335 added a commit to elad335/rpcs3 that referenced this pull request Apr 10, 2019
@elad335
Maken sys_rsx_context_iomap more flexible
6ea18b6 
Theres no way vm::main would be allowed for rsx memory as expected by RPCS3#5677.. Even changed sdk version to match this game and it still failed on decr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kd-11 kd-11 kd-11 approved these changes

Assignees
No one assigned
Labels
Bugfix RSX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elad335 @kd-11 @Nekotekina @AniLeo