Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPU Analyser improvements ("Giga") #5923

Merged
merged 3 commits into from May 11, 2019
Merged

Conversation

Nekotekina
Copy link
Member

@Nekotekina Nekotekina commented May 5, 2019

These changes are supposed to be tested with the following settings:

  • SPU LLVM
  • Giga block size

This is literally first working version from 10 min ago so don't expect much.

@dio-gh
Copy link
Contributor

dio-gh commented May 5, 2019

God of War: Collection [BCES00791] now crashes when starting with a clear SPU cache.

Logfile: gowc_RPCS3.log.zip
SPU logfile: gowc_spu.log.zip

@legend800
Copy link

Yeah I just get Fatal Error in all games, even with no SPU cache. Nfl Blitz is the only one I could find that could at least boot with it.

RPCS3.log

@Nekotekina
Copy link
Member Author

Some games should work now.

@legend800
Copy link

Still getting fatals on all games with the new build.

@Kravickas
Copy link
Contributor

Kravickas commented May 5, 2019

Is it even possible for u Neko to find out from logs why some parts of audio (music in menu) doesnt work with Giga mode ? Its old problem.

@Nekotekina
Copy link
Member Author

From logs very unlikely. Need to bisect it live.

@digitaldude555
Copy link

Metal Slug 3 goes ingame with spu llvm giga, when you close the game rpcs3 crashes though.

@motorolah
Copy link

Ratchet & Clank: Tools of Destruction now crashes before the prologue's video, while on master it does not.

@Nekotekina Nekotekina force-pushed the master branch 2 times, most recently from b034094 to e3ca4dd Compare May 6, 2019 12:52
@Kravickas
Copy link
Contributor

Grand Theft Auto IV [NPEB00882] segfaulting beforte showing window

Log and spu log
Grand Theft Auto IV [NPEB00882].zip

@QuaiGoner
Copy link

QuaiGoner commented May 6, 2019

Red Dead Redemption Fatal Error on boot
RPCS3.log
On second boot it was able to compile PPU, but after SPU Recompiler initializing it hangs
RPCS3.log

@Kravickas
Copy link
Contributor

Grand Theft Auto IV [NPEB00882]

still segfaulted, but even after that it opened window and tried to run and build something
Bez názvu
log, spu logGrand Theft Auto IV [NPEB00882].zip

@Kravickas
Copy link
Contributor

Kravickas commented May 7, 2019

Do u want to continue ? Would be probably better if u get the game yourself or call it too ''broken'' game to fix in Giga :D

Grand Theft Auto IV [NPEB00882]

still segfault, this time no window
Grand Theft Auto IV [NPEB00882].zip

@theoldsport
Copy link

theoldsport commented May 8, 2019

A simpler game that segfaults on giga is Supersonic Acrobatic Rocket-Powered Battle-Cars [NPUB30035]
image

Log-
RPCS3.zip

@legend800
Copy link

Everything is pretty much broken atm. I would hold off on testing until we get some fix commits to minimizing pinging everyone with effectively the same issue.

@Nekotekina Nekotekina force-pushed the master branch 2 times, most recently from 0760702 to 8b4cbe6 Compare May 8, 2019 12:48
@Nekotekina
Copy link
Member Author

Fixed one compatibility issue.

@Nekotekina Nekotekina force-pushed the master branch 5 times, most recently from a45aa5d to 9a12373 Compare May 9, 2019 19:25
@Kravickas
Copy link
Contributor

Kravickas commented May 9, 2019

small update, few builds ago u fixed sound in menu of NHLs

spu giga doesnt crash (tested with only game) when u build some giga cache with asmjit

Causes fatal error inside LLVM.
@isJuhn
Copy link
Contributor

isJuhn commented May 10, 2019

Spider-Man Shattered Dimensions [BLES00946] now boots fine

@Nekotekina Nekotekina changed the title [WIP] SPU LLVM Giga SPU Analyser improvements ("Giga") May 11, 2019
@Nekotekina Nekotekina merged commit 8194c92 into RPCS3:master May 11, 2019
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 11, 2019
Use GHC calling convention directly for SPU object entry points.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 11, 2019
Use GHC calling convention directly for SPU object entry points.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 11, 2019
Avoid returns from the recompiler gateway, favoring tail calls.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 11, 2019
Avoid returns from the recompiler gateway, favoring tail calls.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 11, 2019
Use GHC calling convention directly for SPU object entry points.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 11, 2019
Avoid returns from the recompiler gateway, favoring tail calls.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 12, 2019
Avoid returns from the recompiler gateway, favoring tail calls.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 12, 2019
Renewed and adapted for PIC and all branch types.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 12, 2019
Avoid returns from the recompiler gateway, favoring tail calls.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 12, 2019
Renewed and adapted for PIC and all branch types.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 12, 2019
Renewed and adapted for PIC and all branch types.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 12, 2019
Use GHC calling convention directly for SPU object entry points.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 12, 2019
Avoid returns from the recompiler gateway, favoring tail calls.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 12, 2019
Renewed and adapted for PIC and all branch types.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 14, 2019
Use GHC calling convention directly for SPU object entry points.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 14, 2019
Avoid returns from the recompiler gateway, favoring tail calls.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 14, 2019
Renewed and adapted for PIC and all branch types.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 14, 2019
Use GHC calling convention directly for SPU object entry points.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 14, 2019
Avoid returns from the recompiler gateway, favoring tail calls.
This may address performance degradation after RPCS3#5923.
Nekotekina added a commit to Nekotekina/rpcs3 that referenced this pull request May 14, 2019
Renewed and adapted for PIC and all branch types.
This may address performance degradation after RPCS3#5923.
@SimoSbara
Copy link

SimoSbara commented May 14, 2019

Heavy Rain BCES00797 crashes at giga block size.

EDIT: on the second attempt the game boots but crashes after 1 minute. https://gyazo.com/4302d4395b23ec86042140ac061ebfbc.png

log:
RPCS3.log

@arcadee1977
Copy link

arcadee1977 commented May 20, 2019

@Nekotekina Sonic unleashed dropped 10+FPS in this PR!(8063-50FPS ;8089--36FPS)
Settings: SPU LLVM+SAFE ( In 8089, SPU LLVM FPS=SPU ASMJIT FPS? )

未标题-1
8089

未标题-2
8063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet