Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/Input: add color picker for DS4 Controller LEDs #5929

Merged
merged 1 commit into from May 9, 2019

Conversation

Megamouse
Copy link
Contributor

No description provided.

@Megamouse Megamouse changed the title Qt/Input: add color picker for DS4 Controller LEDs [WIP] Qt/Input: add color picker for DS4 Controller LEDs May 7, 2019
@ghost
Copy link

ghost commented May 7, 2019

No issues with building on Ubuntu 19.04 (gcc 8.3.0).

The controller image looks jagged on my HiDPI screen, however. I don't know how well you can tell from this picture:

controllerhidpi

I personally don't see an issue with the way it looks in master. Is it as big as in the picture above on standard definition?

@Megamouse
Copy link
Contributor Author

It fills the space on 1080p screens but lately it is super small on highdpi screens. Idk if it looks jagged because of the scaling or if the source image is simply not good enough

@MSuih
Copy link
Member

MSuih commented May 7, 2019

That's odd, it looks much smaller for me, same size as current master, but I'm on 1080p at 100% scaling. Some kind of scaling issue I guess, is it caused by the lack of setDevicePixelRatio or what?

image

As for it being jaggy, that could just be caused by the original artwork being stretched beyond it's limits. You can find the PNG file in rpcs3/Icons/controller.png of source. That artwork has multiple mistakes anyways, I'd say it's due to redrawing.

@Megamouse
Copy link
Contributor Author

Guess I'll have to investigate then

@ghost
Copy link

ghost commented May 7, 2019

As for it being jaggy, that could just be caused by the original artwork being stretched beyond it's limits.

Yup, this is it. At the correct size it'll be decent.

@ghost
Copy link

ghost commented May 8, 2019

I actually did get this to build and works to change my DS4's led color on Linux. So that's cool thanks.

I actually wanted to just have it not change my led/brightness at all, because Steam sets it, but I'm not sure if that's possible. Not sending the data to buffer 8/9/10 in SendVibrateData() just results in the LED actually turning off.

@Megamouse
Copy link
Contributor Author

this might need a checkbox or something to enable it similar to the vibration

@Megamouse
Copy link
Contributor Author

Hmm I couldn't find a way to read the old LED state or to prevent it from being updated without disabling the Rumble as well. So for now we have to stick with LEDs being updated.

But I fixed a bug that kept the selected color even when you didn't save it.

I'll look into the controller background image problems next.

@Megamouse Megamouse changed the title [WIP] Qt/Input: add color picker for DS4 Controller LEDs Qt/Input: add color picker for DS4 Controller LEDs May 9, 2019
@Megamouse
Copy link
Contributor Author

I removed the resizing of the icon for now.

@Megamouse Megamouse merged commit fce9d6a into RPCS3:master May 9, 2019
@Megamouse Megamouse deleted the colorful_ds4 branch May 9, 2019 20:06
@Kravickas
Copy link
Contributor

just transfer everything to vector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants