Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Add custom pad configs #5960

Merged
merged 2 commits into from May 16, 2019
Merged

Qt: Add custom pad configs #5960

merged 2 commits into from May 16, 2019

Conversation

Megamouse
Copy link
Contributor

Add a custom pad config for every game.

Configs will be saved per game in config/custom_input_configs

@Hasster1
Copy link

What happened with old pr?

Copy link
Contributor

@gidan80 gidan80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something not working:

  • When using keyboard it works well, but if i try to setup a custom xinput it stick with the default xinput configuration.

  • While ingame, if you change the main config instead of the custom one the handler sticks to the main. Should be better to alwais prioritize the custom config over the main pads config.

  • If you try to remove a custom config (pad or emu conf) and you answer no to the confirmation dialog, it removes the config icons anyway.

}
if (gameinfo->hasCustomPadConfig)
{
QAction* remove_custom_pad_config = remove_menu->addAction(tr("&Remove Custom Configuration"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QAction* remove_custom_pad_config = remove_menu->addAction(tr("&Remove Custom Pad Configuration"));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@Megamouse
Copy link
Contributor Author

I think I fixed all the problems @gidan80 found

@gidan80
Copy link
Contributor

gidan80 commented May 14, 2019

Thank you. Last suggestion/correction: while ingame, if you remove the custom config, the handler should fall back to the main config.

Add a custom pad config for every game.
@Megamouse
Copy link
Contributor Author

@gidan80 added that as well

@gidan80
Copy link
Contributor

gidan80 commented May 16, 2019

Well done. Thank you again for taking care. No bugs left i think, so you can merge it when you're ready.

@Megamouse Megamouse merged commit 9aa0831 into RPCS3:master May 16, 2019
@Megamouse Megamouse deleted the padConfig branch May 16, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants