New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt: Add custom pad configs #5960
Conversation
What happened with old pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is something not working:
-
When using keyboard it works well, but if i try to setup a custom xinput it stick with the default xinput configuration.
-
While ingame, if you change the main config instead of the custom one the handler sticks to the main. Should be better to alwais prioritize the custom config over the main pads config.
-
If you try to remove a custom config (pad or emu conf) and you answer no to the confirmation dialog, it removes the config icons anyway.
rpcs3/rpcs3qt/game_list_frame.cpp
Outdated
} | ||
if (gameinfo->hasCustomPadConfig) | ||
{ | ||
QAction* remove_custom_pad_config = remove_menu->addAction(tr("&Remove Custom Configuration")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QAction* remove_custom_pad_config = remove_menu->addAction(tr("&Remove Custom Pad Configuration"));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
I think I fixed all the problems @gidan80 found |
Thank you. Last suggestion/correction: while ingame, if you remove the custom config, the handler should fall back to the main config. |
Add a custom pad config for every game.
@gidan80 added that as well |
Well done. Thank you again for taking care. No bugs left i think, so you can merge it when you're ready. |
Add a custom pad config for every game.
Configs will be saved per game in config/custom_input_configs