Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk: check_window_status fixes for linux #6006

Merged
merged 2 commits into from May 24, 2019
Merged

Conversation

Whatcookie
Copy link
Member

I've installed all 3 amd drivers on linux along with anv and found some things that need changing.

I've verified that ANV works well and doesn't require any workaround for window resizing.

AMDVLK and the proprietary amd driver both require workarounds to enable window resizing on linux unfortunately. However, most users are already using RADV, and we can recommend those who aren't to switch. (The userbase of these drivers is so small that no one reported window resizing being broken until I bothered to install them myself)

I've also added a second commit that prints a recommendation to install RADV if you use amdvlk or the prop driver on linux. It's using LOG_SUCCESS because WARNING isn't visible by default. I'm not sure if that's the best way to notify users.
The log commit is separate so we can drop it if necessary.

@Whatcookie Whatcookie changed the base branch from master to WIP May 23, 2019 00:08
@Whatcookie Whatcookie changed the base branch from WIP to master May 23, 2019 00:08
Intel ANV has been tested and verified to work without workaround
AMDVLK and the proprietary AMD driver have been confirmed to require workaround for window resizing
@kd-11
Copy link
Contributor

kd-11 commented May 23, 2019

Thanks for testing ANV and AMDVLK. You can use a higher log level, even LOG_ERROR or LOG_FATAL for the driver warning since nobody ever reads the LOG_SUCCESS messages anyway. LOG_FATAL would grab their attaention with the purple text of death, but I feel it would be a misuse, so just use LOG_ERROR instead.

@Whatcookie
Copy link
Member Author

I've switched it to use LOG_ERROR.

@kd-11 kd-11 merged commit c348fec into RPCS3:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants