Fix pad interception #6031
Merged
Fix pad interception #6031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
force-pushed
the
cellMsgDialogAbort
branch
3 times, most recently
from
ba8f0aa
to
926c673
Compare
Megamouse
changed the title
Megamouse
changed the title
Megamouse
force-pushed
the
cellMsgDialogAbort
branch
3 times, most recently
from
f007128
to
f501dc6
Compare
Megamouse
force-pushed
the
cellMsgDialogAbort
branch
from
f501dc6
to
1254f34
Compare
Megamouse
changed the title
Megamouse
force-pushed
the
cellMsgDialogAbort
branch
from
1254f34
to
d6705d5
Compare
kd-11
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that keeps the pad input intercepted after a game aborts a message dialog while using Qt dialogs instead of native dialogs.
(In case you are wondering: QDialog::rejected was not signaled in my tests)
Native dialogs now also skip the on_close callback since it should not be called in this function on real hardware (correct me if I'm wrong).
Also fixes #6082 by setting the data length in cellPadGetData to 0 in case the pads are intercepted.