New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsx: Surface cache fixes #6213
rsx: Surface cache fixes #6213
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I can confirm the same issue as Kirbyguy22, it crashes when loads 3D model in car dealer. (same error in the log as Kirbyguy22) |
The GT Academy 2013 and GT6 reflection are fully fixed. (remains problem "mirror" view in the bumper camera and 2D trees aren't transparent background) |
There are other complications with the PR, I'll ask for a retest when ready. |
@jenci8888 Confirm the memory corruption should be fixed now. |
Looks like I accidentally broke refelections again. Ugh. |
- After splitting, the sections may not be referenced at all for anything other than just pixel storage - In such cases, either merge down or sample from the upstream source instead
Fixed now. I had some debugging code still hanging around. |
Valkyria Chronicles still looks good. I tested a smattering of other games (Ni no Kuni, Minecraft, Trails of Cold Steel, Katamari, Mass Effect) and couldn't find any obvious regressions. |
It seems this PR breaks GT5 for me. It fails with error It doesn't matter if i choose SPU Block Size Safe or Mega. I had attached logs from previous version (8386), this version (8391) and the last at the moment (8410) |
Reimplementation of #6205
Should fix some of the regressions in #5983