Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Implement separate viewport raster clipping #6224

Merged
merged 1 commit into from Jul 19, 2019
Merged

rsx: Implement separate viewport raster clipping #6224

merged 1 commit into from Jul 19, 2019

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Jul 18, 2019

  • Merge viewport raster window and scissor into one clipping region
  • Viewport raster clip is different from viewport geometry clipping in
    hardware as the latter is configurable separately

Fixes rendering outside the active viewport window in games like hotline miami and deadly premonition.

@kd-11 kd-11 force-pushed the fixes branch 3 times, most recently from 1ab441b to 70eee87 Compare July 18, 2019 14:47
@kd-11
rsx: Implement separate viewport raster clipping
1fc6ca6 
- Merge viewport raster window and scissor into one clipping region
- Viewport raster clip is different from viewport geometry clipping in
hardware as the latter is configurable separately
@digitaldude555 digitaldude555 mentioned this pull request Jul 18, 2019
Closed
@Emulator-Team-2
Copy link

Mini-map is fixed now in Initial D Extreme Stage.

Initial D Extreme Stage

Before:
1
After:
2

@jenci8888 jenci8888 mentioned this pull request Jul 18, 2019
Closed
@CookiePLMonster
Copy link
Contributor

Hotline Miami 2 letterboxing confirmed fixed.

@Kravickas
Copy link
Contributor

Kravickas commented Jul 18, 2019 •
edited

Fixes black bars in BTS
obrazek

obrazek

Fixes ground textures in WS, but break trees and fans. I would need this pr + csaa one together.
obrazek

obrazek

@kd-11 kd-11 merged commit b5a2f0d into RPCS3:master Jul 19, 2019
@Kravickas Kravickas mentioned this pull request Jul 19, 2019
Closed
@Zolika1351
Copy link

Causes black bars to appear in some Plants vs. Zombies seed icons
pvzblackbars

@Josivan88
Copy link

Josivan88 commented Jul 19, 2019 •
edited

Heavy visual glitches on 007 Legends and Goldeneye 007 reloaded after this PR:
Before:
Before
Log
RPCS3 before.log.gz
RSX Capture in 8395
https://drive.google.com/file/d/17PKL7iGPhG54GI4eTW1vOIaqXmLyZnTS/view?usp=sharing
After:
After
Log
RPCS3 after.log.gz
RSX Capture in 8397
https://drive.google.com/file/d/1zG_tXUYtjBjdaLL6cCuhMCaJ4FeuuMp4/view?usp=sharing
anything else i am here to help

@kd-11
Copy link
Contributor Author

kd-11 commented Jul 19, 2019

I can't debug without RSX capture file. If you find a bug make sure to attach one, preferrably captured with the working version.

@Josivan88
Copy link

Updated comment with RSX Capture @kd-11 , before and after.

@kd-11 kd-11 mentioned this pull request Jul 20, 2019
Merged
@kd-11
Copy link
Contributor Author

kd-11 commented Jul 20, 2019

Regressions should be fixed by #6236

This was referenced Aug 1, 2019
Closed
Closed
@alexloxldlol alexloxldlol mentioned this pull request Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kd-11 @Emulator-Team-2 @CookiePLMonster @Kravickas @Zolika1351 @Josivan88