Minor fixups #6267
Merged
Minor fixups #6267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Jul 27, 2019
| set(SRC_FILES | ||
| about_dialog.cpp | ||
| auto_pause_settings_dialog.cpp | ||
| breakpoint_handler.cpp |
There was a problem hiding this comment.
This really looks like a pain in the ass to manage.
Does VS do this automatically?
There was a problem hiding this comment.
I dunno, you just add or remove line with source name.
There was a problem hiding this comment.
Just wondering. What's the reason for this change? Was the old implementation faulty?
There was a problem hiding this comment.
GLOB with *.cpp is one of the possible culprits for unnecessary full rebuilds. Keeping file list is just a recommended way of doing this. Also it makes sure that reconfiguration happens on rebuild.
Add get_sint_t.
Nekotekina
force-pushed
the
fixup
branch
3 times, most recently
from
ea89112
to
227182e
Compare
Moved Atomic.h to util/atomic.hpp List source files in CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.