Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: improve trophy manager icons for high dpi setups #6271

Merged
merged 2 commits into from Jul 27, 2019

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Jul 27, 2019

Added a small simplification to the game list icon logic. I hope this will be slightly faster. If it is slower for some reason then I will revert this commit.
So please test the icon resize in the game list if you have a huge amount of games (normal screen OR high dpi screen).

Added the high dpi improvements that can already be seen in the game list and in the save data manager to the trophy manager.

Added the background icon color that is already used for the game icons to the trophy icons.

Comparison: (Note my custom black background color on the trophy icons)

comparison

@Megamouse Megamouse added the GUI label Jul 27, 2019
@Asinin3
Copy link
Contributor

Asinin3 commented Jul 27, 2019

Before:
rpcs3_Fe2QtNkJya
After:
image
Nice work, the speed is the same though still takes me around 2:30~ to open the trophy screen for the first time (on my massive game library with probably around 600 trophy entries). Once it's cached into ram then all subsequent runs take around ~30sec to open the list.

@Megamouse Megamouse merged commit 65134f7 into RPCS3:master Jul 27, 2019
@Megamouse Megamouse deleted the icons branch July 27, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants