Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny fix of vm::check_addr #6319

Merged
merged 2 commits into from Aug 10, 2019
Merged

Tiny fix of vm::check_addr #6319

merged 2 commits into from Aug 10, 2019

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Aug 9, 2019

Fix stack memory state checking, boundaries may be "allocated" but not mapped (guard pages).

@Nekotekina
Copy link
Member

page_mapped constant doesn't make any sense.
page_allocated bit should always be checked so it can be assumed and ORed with flags just inside check_addr.
Checking other bits should always be explicit.
Checking only page_writable is also fine since it implies page_readable (there is no "write-only" pages)

@elad335
Copy link
Contributor Author

elad335 commented Aug 10, 2019

There is no such thing as page allocated with no-access on ps3, maybe the ability to do that should be removed from vm::page_protect.
For now im defaulting check_addr to readable + allocated.

@AniLeo AniLeo requested a review from Nekotekina August 10, 2019 15:45
@Nekotekina Nekotekina merged commit 94d3300 into RPCS3:master Aug 10, 2019
@elad335 elad335 deleted the check_addr branch August 10, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants