Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatched enum string formats in sys_config #6369

Merged
merged 1 commit into from Aug 18, 2019
Merged

Fix mismatched enum string formats in sys_config #6369

merged 1 commit into from Aug 18, 2019

Conversation

JohnHolmesII
Copy link
Contributor

The enum fed into the template did not match the enum values used in the switch. It was discovered through warnings. Do we need to implement a string formatter for the third enum type?

@Megamouse
Copy link
Contributor

It wouldn't hurt, but is it really used in any log message at this moment?

@JohnHolmesII
Copy link
Contributor Author

I have no idea, but I think someone wanted those enums printed, since they took the time to write 2 of the three. Or not.

@JohnHolmesII JohnHolmesII marked this pull request as ready for review August 18, 2019 16:06
@Megamouse Megamouse merged commit 5817e2a into RPCS3:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants