Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Display "Reboot With Custom/Global config" on running game #7347

Merged
merged 2 commits into from Jan 30, 2020

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Jan 30, 2020

Example on a running game:
image

And fix re/booting when running a game, using disabled "Show Boot Game Dialog" setting and using these options in game context menu.

@Megamouse
Copy link
Contributor

Why not?
Also, there are more ways to reboot games that are currently running

@Megamouse
Copy link
Contributor

Maybe just rename it to reboot if !stopped and gameid is titleid

@elad335
Copy link
Contributor Author

elad335 commented Jan 30, 2020

It's not working atm for reboots, its basically a no-op when its running.

@elad335 elad335 force-pushed the game-context branch 2 times, most recently from dc674b6 to 94e8c58 Compare January 30, 2020 18:19
@elad335 elad335 changed the title Qt: Don't display "Boot With Custom/Global config" on running game Qt: Display "Reboot With Custom/Global config" on running game Jan 30, 2020
Copy link
Contributor

@Megamouse Megamouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not working, then why change it to reboot?

rpcs3/rpcs3qt/game_list_frame.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/game_list_frame.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/game_list_frame.cpp Outdated Show resolved Hide resolved
@elad335
Copy link
Contributor Author

elad335 commented Jan 30, 2020

Probably needs fixing because it seems intentional to be able to reboot this way.

@elad335 elad335 force-pushed the game-context branch 2 times, most recently from bce3ea6 to 1176e6c Compare January 30, 2020 19:26
@elad335
Copy link
Contributor Author

elad335 commented Jan 30, 2020

Bug fixed: if "Show Boot Game Dialog" setting was not selected, rebooting won't be allowed at all.
Fixed by default initializing variables properly (ShowConfirmationBox does not write back value on failure).

@Megamouse Megamouse merged commit 48a847d into RPCS3:master Jan 30, 2020
@elad335 elad335 deleted the game-context branch January 30, 2020 21:21
@Megamouse Megamouse added the GUI label Feb 5, 2020
elad335 added a commit to elad335/rpcs3 that referenced this pull request Mar 8, 2020
Show "Reboot" on current running game when there's no config.
Nekotekina pushed a commit that referenced this pull request Mar 9, 2020
Show "Reboot" on current running game when there's no config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants