New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gsl::span for std::span (c++20) #7531
Conversation
Just for reference, here are some outputs. GCC and Clang are around the corner, but MSVC is just a confused child it seems. |
@AniLeo clang does support |
d81f9bd
to
5fa68aa
Compare
@AniLeo it looks like this might be good now. It just looks like a few files might not have gotten the full treatment (complain about Utilities\span.h not existing): |
Everything should work now if you update the compilers. |
Any update? |
I have confirmed that span is fully replaceable, but the dockerfile will need to be updated to 18.04. @hcorion Is moving to 18.04 or even 20.04 an option for the docker files, or do you have other blockers? Only changes required are at least 18.04 and gcc=10 instead of 9 |
The AppImage requires support for the lowest still supported LTS Ubuntu version, which usually means you have to build on that version. 16.04 support ends April 2021, so the plan was to wait for that before making the move to 18.04. Though it is possible that a 18.04 generated binary might still work on 16.04, I haven't tested it |
Makes sense. This isn't the most pressing, so it may just be worth waiting til april. |
Needs conflicts solved |
d359d23
to
9f6d37e
Compare
This is just to track implementation progress of std::span in the main 3 compilers we use. It is not possible to do such change now because none of the compilers are ready for std::span.
Implemented on currently used compilers (0/3):
According to https://en.cppreference.com/w/cpp/compiler_support Clang should support it since version 7, but importing
<span>
doesn't work