Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cellSaveData: Add some error checks for fixedSet, fileSet params #7652

Merged
merged 1 commit into from Mar 1, 2020
Merged

cellSaveData: Add some error checks for fixedSet, fileSet params #7652

merged 1 commit into from Mar 1, 2020

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Mar 1, 2020 •
edited

  • Don't return an error on fileSet->fileBuf == null if fileBufSize is 0. (there may be more to that, todo)
  • Check fixedSet->dirName using the sysutil name checking.
  • Check fileSet->fileName using sysutil name checking, check 8.3 format validity.
  • Check fixedSet->option.

@elad335 elad335 force-pushed the savedata-wip branch 3 times, most recently from f851f21 to 1465f1c Compare March 1, 2020 07:40
@elad335 elad335 force-pushed the savedata-wip branch 2 times, most recently from 8431ed9 to 843afff Compare March 1, 2020 08:04
@Nekotekina
Copy link
Member

escape/unescape may not be useful, but it's not much overhead and it's also a usage example

@elad335 elad335 force-pushed the savedata-wip branch 2 times, most recently from d134ea1 to 7b1b0c4 Compare March 1, 2020 08:42
@elad335 elad335 requested a review from Nekotekina March 1, 2020 08:42
@Megamouse Megamouse added Firmware: HLE Savedata Anything that involves cellSaveData labels Mar 1, 2020
@Nekotekina Nekotekina merged commit ffd5a9e into RPCS3:master Mar 1, 2020
elad335 added a commit to elad335/rpcs3 that referenced this pull request Mar 1, 2020
@elad335
cellSaveData: followup to RPCS3#7652
63f6dd2
Nekotekina pushed a commit that referenced this pull request Mar 1, 2020
@elad335 @Nekotekina
cellSaveData: followup to #7652
7dfd50d
@elad335 elad335 deleted the savedata-wip branch March 15, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nekotekina Nekotekina Nekotekina approved these changes

Assignees
No one assigned
Labels
Firmware: HLE Savedata Anything that involves cellSaveData
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elad335 @Nekotekina @Megamouse