Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

プレイステーション 3D #7657

Merged
merged 5 commits into from
Mar 7, 2020
Merged

プレイステーション 3D #7657

merged 5 commits into from
Mar 7, 2020

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Mar 1, 2020

Implements stereo 3D rendering for games that support it.
Currently, only 720p resolution is allowed due to how the frame packing works.
To enable, set display out to 720p (default) and set 'Enable 3D' to true in config file. This will enable 3D which is presented via anaglyph filter to the user.
Real display 3D is coming soon, but I don't have a compatible display myself, so it may take a few more days.

@ghost
Copy link

ghost commented Mar 1, 2020

Games tested using RX 580:

SUPER STARDUST™ HD [NPEA00014] anaglyph filter working fine.

STARDUST_3D

de Blob 2 [NPEB00534] anaglyph filter working fine.

DEBLOB2

Doom 3 BFG Edition [BLUS31024] anaglyph filter working fine.

Doom3

@legend800
Copy link

legend800 commented Mar 1, 2020

2020-03-01 10_17_23-FPS_ 30 01 _ Vulkan _ 0 0 9-f1469b3b-3d _ The House Of The Dead_ OVERKILL™ Exten
Anaglyph works fine for HOD Overkill also.

Can't wait for Stereo 3D support (I have a monitor for testing). ;)

Update/Notes:

  • Anaglyph 3D already worked on HOD Overkill on master, which is confusing, not sure what this pr adds specifically
  • Working also on Master: Captain America (3d modes: top/down, SBS, anaglyph)
  • I have these 3D games but don't see a menu option, maybe dependent on stereo 3D and prompts during load?
    RR7, MS 3D Rift, Gow Origins, MS Apoc., Wipeout HD
  • Related git issue: 3D is not supported #5471

@kd-11
Copy link
Contributor Author

kd-11 commented Mar 1, 2020

@legend800 You need to enable 3D in the config file. Will add a proper checkbox later.
Some games have anaglyph support built-in and don't need 3D to work, this PR isn't using the anaglyph filters these games have; it's simulating 3DTV with anaglyph which is different.
I can confirm Miku PDF and MS 3D Rift are working correctly as well.

@MarioSonic2987
Copy link
Contributor

Anaglyph filter also works in Tekken Tag Tournament 2:
image

@legend800
Copy link

Ugh, I had it set to True instead of true. :)

Works great! Two issues of note:

  1. MS Apoc. only renders 4:3 (squished) - MS Pacific Rift renders proper widescreen:
    2020-03-01 17_02_05-Window

  2. Ridge Racer black screens in 3D mode. Perfect in reg. 2D mode.
    2020-03-01 16_54_09-Window
    2020-03-01 16_55_38-Window
    RPCS3.zip

Here's some notes (from my collection):
o Requires 3D detection(works): GOW Origins, HOD Overkill, MS 3D Rift, MS Apoc., RR7, Wipeout HD
o All support anaglyph – HOD Overkill and Captain America have it without 3D detection
o Captain America supports T/D and SBS (without detection), will need to wait to check if it supports stereo once available
o Added more screens to Media on Discord

@Zangetsu38
Copy link
Contributor

@legend800 during my first 3d wortks, i have get hurt on RR7 and mortal kombat, is probably same here

@MSuih
Copy link
Member

MSuih commented Mar 2, 2020

Just a sidenote; wikipedia has a list of all games with 3D support: https://en.wikipedia.org/wiki/List_of_PlayStation_3_games_with_3D_support

@MsDarkLow
Copy link
Contributor

MsDarkLow commented Mar 2, 2020

Crysis 3 turns into a blackscreen when attempting to enable it in the main menu.
1
2
Log: RPCS3 Crysis3D.zip

@kd-11
Copy link
Contributor Author

kd-11 commented Mar 3, 2020

Everything seems to have gone 'smoothly' with crysis according to the log. It even sets up the modechange correctly and gets into 3D mode. I'll check what's going on with it.

@kd-11
Copy link
Contributor Author

kd-11 commented Mar 3, 2020

Turns out cryengine is using a stereo rendering pipeline that is unexpected by rpcs3. Needs some more polishing.

@kd-11
Copy link
Contributor Author

kd-11 commented Mar 4, 2020

Cryengine issues are fixed. However, currently it is going through the wcb->fault path which is slow, I'll try and get optimizations working.

@kd-11
Copy link
Contributor Author

kd-11 commented Mar 4, 2020

The last commit should have fixed cryengine performance issues when 3D is enabled. If there is still a game that is not working with 3D, let me know.

@legend800
Copy link

What about the 2 issues I reported above?

@kd-11
Copy link
Contributor Author

kd-11 commented Mar 4, 2020

Did you check?

  1. Aspect ratio could likely just be the game being broken, would need to test on real 3D tv with real PS3 to confirm actual rendering resolution. Most 3D resolutions are not actually 16:9 but maybe it is expected that the image will be stretched to fill screen. They're usually smaller in width to account for the performance loss and I guess they're rendering in anamorphic. You can fix it by using stretch option for now while I think of a workaround.
  2. Is Ridge racer still black screen?

@Zangetsu38
Copy link
Contributor

@kd-11 rr7 is very special, it using self, so it reboot, and this causing problem, like i said, i have get very hurt on it :/

@legend800
Copy link

Ridge Racer 7 is now more broken. Use 3D? string is now an error string. If selecting 3D it hits an exception instead of the perm black screen like before

2020-03-04 23_09_43-Window

2020-03-04 23_11_44-Window

RPCS3.log.gz

- In case of gamma correction or other effects, they may require shader access.
- BGRA8_UNORM is usually safe to use directly without staging memory.
…le images

- Allows sourcing flip data from the blit engine resources which avoids expensive flush and re-upload
@kd-11 kd-11 changed the title [TESTERS NEEDED][WIP] プレイステーション 3D [WIP] プレイステーション 3D Mar 7, 2020
@kd-11 kd-11 changed the title [WIP] プレイステーション 3D プレイステーション 3D Mar 7, 2020
@kd-11
Copy link
Contributor Author

kd-11 commented Mar 7, 2020

@legend800 Could you retest?

@kd-11 kd-11 merged commit 70f2577 into RPCS3:master Mar 7, 2020
@legend800
Copy link

Text fixed, no crash now but the gfx are pretty messed up. :P

2020-03-07 09_47_22-Window

@dio-gh
Copy link
Contributor

dio-gh commented Mar 7, 2020

Wow, that's actually kinda pretty :D

@kd-11
Copy link
Contributor Author

kd-11 commented Mar 7, 2020

I already opened a tracker for this one several hours ago here

@legend800
Copy link

Also, I'm getting crashes when exiting games and playing in 2D.

Example from Split Second (non-3d game):
RPCS3.zip

@kd-11
Copy link
Contributor Author

kd-11 commented Mar 7, 2020

That's very likely caused by something else and not this PR.

@kd-11 kd-11 mentioned this pull request Mar 7, 2020
@xperia64
Copy link
Contributor

xperia64 commented Mar 7, 2020

How are alternate 3D modes/shaders going to be tracked?

For anaglyph, I'm a big fan of Dubois Red-Cyan, as it drastically reduces eye strain for me: https://github.com/dolphin-emu/dolphin/blob/master/Data/Sys/Shaders/Anaglyph/dubois.glsl

And of course side-by-side support would make this work nicely in VR without having to decode Red-Cyan and dealing with the issues there.

@kd-11
Copy link
Contributor Author

kd-11 commented Mar 7, 2020

Alternate conversion modes will be added, I started with full color as proof of concept only. 3D options isn't even added to menus yet because it's not finished yet. The 3D output mode will have a proper dropdown selector in the near future.

@tufeixp
Copy link

tufeixp commented Feb 20, 2023

Come on! please add 3d sbs for 3d tvs!

@Darkhost1999
Copy link
Contributor

Come on! please add 3d sbs for 3d tvs!

#13059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants