Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings, fix MSVC warnings #7689

Merged
merged 3 commits into from Mar 4, 2020
Merged

Warnings, fix MSVC warnings #7689

merged 3 commits into from Mar 4, 2020

Conversation

Nekotekina
Copy link
Member

No description provided.

@Nekotekina Nekotekina requested review from Megamouse and kd-11 and removed request for Megamouse March 4, 2020 14:25
@Nekotekina Nekotekina force-pushed the warnings branch 6 times, most recently from e7f28b2 to 3705967 Compare March 4, 2020 16:14
@Nekotekina
Copy link
Member Author

Added formatting for in_addr

@Nekotekina Nekotekina force-pushed the warnings branch 3 times, most recently from 44d0af7 to 11bf2a8 Compare March 4, 2020 17:34
@Nekotekina
Copy link
Member Author

Nekotekina commented Mar 4, 2020 •
edited

Generalized strcpy_trunc to support other types, such as string_view.
Added strncpy_trunc to replace std::strncpy. Generalized case with variable buffer with gsl::span (future std::span).

@elad335
Copy link
Contributor

elad335 commented Mar 4, 2020

Use the new strcpy_trunc in cellGameGetParamString maybe.

@Nekotekina Nekotekina force-pushed the warnings branch 2 times, most recently from 04d804e to 0de4240 Compare March 4, 2020 18:15
@Nekotekina Nekotekina merged commit 250736e into RPCS3:master Mar 4, 2020
This was referenced Mar 4, 2020
Closed
Closed
@knock2one
Copy link

This update broke Ratchet and Clank: Going Commando USA with HDD error. Downgrading fixed the issue.

@RainbowCookie32
Copy link
Contributor

#7694 probably fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Megamouse left review comments

@kd-11 kd-11 Awaiting requested review from kd-11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Nekotekina @elad335 @knock2one @RainbowCookie32 @Megamouse