Untangle RPCS3-specific stuff from Log.cpp #7709

Nekotekina · 2020-03-06T18:21:32Z

Disabled log backup for now.

rpcs3/main.cpp

Part of the work to untangle utilities from RPCS3-specific things.

Minor cleanup

Also use single template with CharT to match fmt::format.

Don't add prefix for first messages.

Megamouse reviewed Mar 6, 2020

View reviewed changes

rpcs3/main.cpp Outdated Show resolved Hide resolved

Nekotekina force-pushed the fixup branch from a0ff985 to 7258ac6 Compare March 6, 2020 19:29

Nekotekina added 2 commits March 7, 2020 10:49

Logs: remove mem-mapped buffer and move instance lock to main.cpp

2209be5

Part of the work to untangle utilities from RPCS3-specific things.

Logs.cpp: more code moved to main.cpp

66b0b78

Nekotekina force-pushed the fixup branch from 7258ac6 to 6fe916c Compare March 7, 2020 08:18

Add fs::error::unknown, don't throw

8461a5c

Nekotekina force-pushed the fixup branch from 6fe916c to 8461a5c Compare March 7, 2020 08:22

Nekotekina added 4 commits March 7, 2020 11:52

Don't throw on invalid whence (return fs::error::einval)

a166d36

Move Log.h to util/logs.hpp

e4a81b1

Move Log.cpp to util/logs.cpp

12a3cdf

Minor cleanup

logs.hpp: minor optimization for non-formatting logs

b726aa5

Also use single template with CharT to match fmt::format.

Nekotekina force-pushed the fixup branch from 9380950 to b726aa5 Compare March 7, 2020 10:52

logs.cpp: print some errors if failed to create logs

7599c66

Nekotekina force-pushed the fixup branch from 9a83dfd to 326714b Compare March 7, 2020 12:32

logs.cpp: fix log format for backward compatibility

19107b2

Don't add prefix for first messages.

Nekotekina force-pushed the fixup branch from 326714b to 19107b2 Compare March 7, 2020 12:33

Nekotekina merged commit 19107b2 into RPCS3:master Mar 7, 2020

Nekotekina changed the title ~~[WIP] Untangle RPCS3-specific stuff from Log.cpp~~ Untangle RPCS3-specific stuff from Log.cpp Mar 7, 2020

Provide feedback