Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellSaveData: Some fixes, formatting fix for the PPU disassembler #7775

Merged
merged 4 commits into from
Mar 14, 2020

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Mar 14, 2020

  • Return ERROR_FAILURE on funcFile deletion failures.
  • Fix adding file entries to PARAM.SFO on error after funcFile.
  • Do not allow to read/write/delete directly system files (such as PARAM.SFO) in funcFile, return param error 70 in this case.
  • PPU Disasm: Fix branches spacing: Null terminator was added at the end which prevented proper spacing.
    So now use std::string fmt formatting and avoid adding null terminator in the first place.

before:
image

after:
image

@elad335 elad335 force-pushed the sys_prx branch 3 times, most recently from 3676eaa to 3040800 Compare March 14, 2020 09:02
@elad335
Copy link
Contributor Author

elad335 commented Mar 14, 2020

Removed permission to alter system files (such as PARAM.SFO) in funcFile by file ops.

@elad335 elad335 force-pushed the sys_prx branch 2 times, most recently from 810c505 to 14fb034 Compare March 14, 2020 09:36
@Nekotekina Nekotekina merged commit c3d3694 into RPCS3:master Mar 14, 2020
elad335 added a commit to elad335/rpcs3 that referenced this pull request Mar 14, 2020
elad335 added a commit to elad335/rpcs3 that referenced this pull request Mar 14, 2020
elad335 added a commit to elad335/rpcs3 that referenced this pull request Mar 14, 2020
elad335 added a commit to elad335/rpcs3 that referenced this pull request Mar 14, 2020
elad335 added a commit to elad335/rpcs3 that referenced this pull request Mar 14, 2020
@elad335 elad335 changed the title cellSaveData/PPU Disasm: Minor fixes cellSaveData: Some fixes, formatting fix for the PPU disassembler Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants