Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Texture cache fixups #7779

Merged
merged 4 commits into from Mar 15, 2020
Merged

rsx: Texture cache fixups #7779

merged 4 commits into from Mar 15, 2020

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Mar 14, 2020

  • Allow cross-aspect merging of resources (DEPTH<->RGBA). This was marked as TODO and a terrible workaround added but it got forgotten.
  • Fix texture cache region check verification to account for other resource types that are theoretically possible for the same range, but may have different properties.

Fixes #7359

kd-11 and others added 3 commits March 14, 2020 23:07
@kd-11
rsx: Implement cross-aspect slice gathering
1cf00da 
- Fixes a data leak that can happen when a surface is rejected due to aspect mismatch.
- Mismatch can lead to rejection due to area covered excluding the RTT and inevitable upload a texture from CPU at the same location.
- Overlapping fbo/shader_read resources are not allowed.
@kd-11
rsx: Improve section scanning when updating surface cache resources i…
07106c3 
…n blit engine.
@kd-11
Merge branch 'master' into rsx_volatile
cbbaccf
@kd-11 kd-11 mentioned this pull request Mar 14, 2020
Closed
@Cervoxx
Copy link

Cervoxx commented Mar 14, 2020 •
edited

Not getting the crash anymore in clanks second level, before I constantly got a crash as detailed in #7359. Yet I keep getting stutters now.

Logs: https://files.catbox.moe/7ry8po.gz

@kd-11 kd-11 changed the title [TESTERS NEEDED] rsx: Texture cache fixups rsx: Texture cache fixups Mar 15, 2020
@kd-11 kd-11 merged commit 7025985 into RPCS3:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ratchet and Clank: ToD [BCES00052] - Regression After #7253
2 participants
@kd-11 @Cervoxx