Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk: Lazy evaluate renderpass scope #7784

Merged
merged 1 commit into from Mar 15, 2020
Merged

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Mar 15, 2020

Rewrites the Vulkan backend's handling of renderpass open/close scopes. This is made possible by previous commits refactoring renderpasses many months ago, as it would have been impossible before to dynamically open and close renderpasses on a global scale. With the new structure, renderpasses are always assumed to be in the open state and individual API driver calls that require renderpasses to be closed have to manually request to close the current renderpass. This allows the GPU to batch together related draw calls significantly improving rendering efficiency.

See https://youtu.be/iJfulnNr-eI

- Spamming the driver with renderpass open/close cycles is bad for performance.
@Nekotekina Nekotekina merged commit d25ba03 into RPCS3:master Mar 15, 2020
@arcadee1977
Copy link

arcadee1977 commented Mar 17, 2020

RDR:
E {RSX [0x0088eb4]} RSX: Dubious query data pushed to cond render!, Please report to developers(q.pending=1)

@Shuneferus
Copy link

Shuneferus commented Mar 22, 2020

Mobile Suit Gundam Senki [BLJS10050]
Hello KD-11 from this pr horizontal lines appear instead of the exhaust smoke from the turbine of the mobile suit.
Image is attached.

RPCS3.log

PR7784

@Shuneferus
Copy link

Hello Kd-11 this regression started from
do pr vk: Lazy evaluate renderpass scope # 7784 0.0.9-9929.

@Shuneferus
Copy link

rpcs3_2020_09_13_00_47_18_474
RPCS3.log
rpcs3_2020_09_13_00_47_21_941
rpcs3_2020_09_13_00_47_22_741

Mobile Suit Gundam Senki [BLJS10050]
Hello KD-11 I believe that this problem may be related to the resolution scale because when increasing the scale from 150 to 300 the lines become more apparent. (On scale 100, the error occurs more with less intensity)
When reporting the first time I had not noticed the mirrored reflections
that occur when driving the turbines when playing in a low light stage (Moon / Space in the Game).
I kindly ask you to analyze the attached images to see if you have any idea of the source of the error.
A hug.

cipherxof added a commit to cipherxof/rpcs3 that referenced this pull request Jun 10, 2021
- Spamming the driver with renderpass open/close cycles is bad for performance.

RPCS3#7784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants