Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements for debugging tools #7802

Merged
merged 5 commits into from Mar 19, 2020
Merged

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Mar 19, 2020

  • Fix a segfault when viewing unmapped memory as image in memory viewer, simply do nothing in this case. Also use super ptr because non-emu threads do not support rsx access violation handling.
  • Remove one '>' or space from the disassembler view, there were 4 characters reserved only for breakpoints which looked weird imo, now there are only 3.
    Also make it consistent with 'no thread' view, add the remaining 3 spaces there as well.
  • Fix memory leaks regarding wrong usage of QImage passed raw pointers in rsx debugger and memory image viewer.
  • Fix a corner case when viewing unaligned spu memory at the end of SPU LS by force aligning the address to 4 bytes. For non-aligned memory view the proper memory viewer tool should be used instead of the disassembler.
  • Avoid a segfault when reading ppu stack contents in debugger.

Also a memory leak.
Fixes a corner case viewing unaligned memory at the end of spu memory.
Also unaligned view isn't suitable for the debugger, for these purposes the memory viewer should be used instead.
@Nekotekina Nekotekina merged commit 1dbb542 into RPCS3:master Mar 19, 2020
@elad335 elad335 changed the title Minor improvements for debugging tools Some improvements for debugging tools Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants